Discussion:
unknown
1970-01-01 00:00:00 UTC
Permalink
For some reason the first line of the patch contains mysterious '>' at the
start, and because of this can't be automatically applied. I usually use "git
format-patch -1" to generate patch from the latest commit, and the resulting
files always look good.
Subject: [PATCH] Added example for %{bitrate} format string.
"doc: add example for %{bitrate} format string" would be a tiny bit better
IMHO.

https://github.com/erlang/otp/wiki/Writing-good-commit-messages is a nice
summary of how to create decent commit messages.
+in the example below.
There was a trailing space in this line; I've removed it. When reviewing
changes with "git diff" or "git log -p", git can highlight trailing whitespace;
I think it even does that by default.

Gregory

Loading...