Strange characters

[Aljosa Vidmar]

Greetings,

I've been using cmus for a while and it's really great! The only problem I
have is in view no. 1 where I get Chinese characters instead of what should
be written there (see this image: Loading Image...

In other music players the band name is displayed correctly. I checked ID3
tags with EasyTag and everything seems fine. Also, for one band I get "<No
Name>", but the album title is displayed correctly.

Any help will be greatly appriciated.


Regards,
Aljosa

[Gregory Petrosyan]

Post by Aljosa Vidmar
Greetings,

Welcome to the list!

Post by Aljosa Vidmar
I've been using cmus for a while and it's really great! The only problem I
have is in view no. 1 where I get Chinese characters instead of what should
be written there (see this image: http://i52.tinypic.com/2ywa9oy.jpg
In other music players the band name is displayed correctly. I checked ID3
tags with EasyTag and everything seems fine. Also, for one band I get "<No
Name>", but the album title is displayed correctly.

Are you using the latest version of cmus — 2.3.3? If no, please upgrade — it
is worth it anyway :-)

If the problem can be reproduced with the latest cmus, can you please upload a
"buggy" file somewhere, so that it'll be possible to debug this issue?

Gregory

[a***@gmail.com]

Are you using the latest version of cmus — 2.3.3? If no, please upgrade —
it
is worth it anyway :-)

Yes, I'm using version 2.3.3.

If the problem can be reproduced with the latest cmus, can you please
upload a
"buggy" file somewhere, so that it'll be possible to debug this issue?

By "buggy file", do you mean audio file?


Aljosa

[Gregory Petrosyan]

Post by a***@gmail.com

Post by Gregory Petrosyan
If the problem can be reproduced with the latest cmus, can you please upload a
"buggy" file somewhere, so that it'll be possible to debug this issue?

By "buggy file", do you mean audio file?

Yes.

                Gregory

[a***@gmail.com]

Alright, below you will find 2 files from separate music albums that don't
display correctly in cmus. File "01-dimmu_borgir-xibir" is the one with
Chinese characters as the album name, and
"03-saturnus-as_we_dance_the_path_of_fire_or_solace" is from an album that
shows up in cmus as "<No Name>" where band name should be.

http://ifile.it/tiq51jc


Aljosa

[Gregory Petrosyan]

Post by a***@gmail.com
Alright, below you will find 2 files from separate music albums that don't
display correctly in cmus. File "01-dimmu_borgir-xibir" is the one with
Chinese characters as the album name, and

Are you sure it is this file? I can't reproduce this bug:

Loading Image...

Post by a***@gmail.com
"03-saturnus-as_we_dance_the_path_of_fire_or_solace" is from an album that
shows up in cmus as "<No Name>" where band name should be.

Thanks, that was an actual bug in cmus! I've already pushed the patch
to "maint" branch of the git repository
(http://gitorious.org/cmus/cmus/commits/maint). It is quite easy to
build cmus from source, so you might try that. Otherwise, cmus 2.3.4
will be out in a week or two, and the fix will be there as well.

                Gregory

[Aljosa Vidmar]

Post by Gregory Petrosyan
http://i.imgur.com/L5Afv.png
I removed the entire album from cmus, then added each file back into cmus

separately, and each time the band name shows as "䐀怀掀掀甀 䈀挀爀最怀爀". I will try
to encode the album into ogg format and see what will happen.

I will wait for the new version and build it from source. Thanks!

[Aljosa Vidmar]

Post by Gregory Petrosyan
I removed the entire album from cmus, then added each file back into cmus
separately, and each time the band name shows as "䐀怀掀掀甀 䈀挀爀最怀爀". I will try
to encode the album into ogg format and see what will happen.

Strange, but encoding the entire album from MP3 to OGG fixed the problem,
although I have no idea what was wrong with original files.

[Gregory Petrosyan]

Post by Aljosa Vidmar

Post by Gregory Petrosyan
I removed the entire album from cmus, then added each file back into cmus
separately, and each time the band name shows as "䐀椀洀洀甀 䈀漀爀最椀爀". I will try
to encode the album into ogg format and see what will happen.

Strange, but encoding the entire album from MP3 to OGG fixed the problem,
although I have no idea what was wrong with original files.

Encoding into Ogg from MP3 did re-write the tags from scratch, and that made
the problem go away.

Can you please remove the ~/.cmus directory (or rename it), then start cmus and
try to only add one song you've sent to me?

Gregory

[Gregory Petrosyan]

Post by Gregory Petrosyan
Can you please remove the ~/.cmus directory (or rename it), then start cmus and
try to only add one song you've sent to me?

I did that and song "01-dimmu_borgir-xibir.mp3" (band, album, song names)
showed correctly. No more Chinese characters.

Hm, that probably means the issue was because of cmus' cache
corruption or something like that. It does not look very debuggable
:-(

Thanks for taking your time to report and help debug this!

                Gregory

[Gregory Petrosyan]

Post by Aljosa Vidmar
I will wait for the new version and build it from source. Thanks!

Just to make it clear: the version you'll obtain by doing

$ git clone -b maint git://gitorious.org/cmus/cmus.git

is the version that'll be released as 2.3.4 (unless new bugs will be
discovered), so if you plan to build from source anyways, you may just as well
do it now :-)

Gregory

[Jasper Olbrich]

Post by Gregory Petrosyan
Thanks, that was an actual bug in cmus! I've already pushed the patch
to "maint" branch of the git repository

Hi, I am reading the mailing list for quite some time now (I'd love to
participate more in the development of cmus, but I'm completely out of
time). Are you sure that the fix you just comitted is correct?
Have a look at the lines 60 and 62 in comment.c. Unless keyvals_get_val
causes some desired side effect, val will be set twice (lines 61+63)

I hope I didn't get something completely wrong...

Keep up the great work!

--
Jasper

[Gregory Petrosyan]

Post by Jasper Olbrich

Post by Gregory Petrosyan
Thanks, that was an actual bug in cmus! I've already pushed the patch
to "maint" branch of the git repository

Hi, I am reading the mailing list for quite some time now (I'd love to
participate more in the development of cmus, but I'm completely out of
time). Are you sure that the fix you just comitted is correct?
Have a look at the lines 60 and 62 in comment.c. Unless keyvals_get_val
causes some desired side effect, val will be set twice (lines 61+63)

Well, "val = keyvals_get_val()" has a desired side effect of changing the
value of "val", so the next assignment will only happen if "val" is becomes
NULL or empty.

Also, I've checked that this patch does fix the problem before committing, so
I am fairly sure it is good.

const char *comments_get_albumartist(const struct keyval *comments)
{
const char *val = keyvals_get_val(comments, "albumartist");

if (track_is_va_compilation(comments))
val = "<Various Artists>";
if (!val || strcmp(val, "") == 0)
val = keyvals_get_val(comments, "artist");
if (!val || strcmp(val, "") == 0)
val = "<No Name>";

return val;
}

Or am I missing something?

Post by Jasper Olbrich
Keep up the great work!

Thanks!

Gregory

[Jasper Olbrich]

Post by Gregory Petrosyan
Well, "val = keyvals_get_val()" has a desired side effect of changing the
value of "val", so the next assignment will only happen if "val" is becomes
NULL or empty.

Indeed...

Post by Gregory Petrosyan
Or am I missing something?

I don't think so. My bad :(