Updates for RoarAudio plugin

[Philipp Schafft]

flum,

I attach a patch for the RoarAudio plugin.
It updates the following:
1. Use roar_libroar_set_server() to set server (This may be needed
for bad NAT firewalls)
2. Use non-blocking connect. Also changes the prio to -3 to be in
front of pulse plugin (feel free to adjust pulse and roarplugin
to -1 and -2). My arguments why I think this is the right way
still stands. See my mail 'Re: RoarAudio output plugin for cmus'
from Tue, 30 Nov 2010 11:55:00 +0100
(<***@priderock.keep-cool.org>)

Hope you like the patch.

Thanks for your work.

[Johannes Weißl]

Hello Philipp,

Post by Philipp Schafft
I attach a patch for the RoarAudio plugin.
1. Use roar_libroar_set_server() to set server (This may be needed
for bad NAT firewalls)
2. Use non-blocking connect. Also changes the prio to -3 to be in
front of pulse plugin (feel free to adjust pulse and roarplugin
to -1 and -2). My arguments why I think this is the right way
still stands. See my mail 'Re: RoarAudio output plugin for cmus'
from Tue, 30 Nov 2010 11:55:00 +0100
Hope you like the patch.

Thanks for the patch! I changed the priority of RoarAudio when I
modified the auto-probing for output plugins. Now they are not only
initialized (which is useless for most plugins because it always
succeeds if the libraries are installed), but also opened.
This caused a very long delay for RoarAudio.

With your patch the delay is gone, so it can have a higher (= lower)
priority than PulseAudio again :-).


Johannes

[Gregory Petrosyan]

Post by Philipp Schafft
flum,
I attach a patch for the RoarAudio plugin.
    1. Use roar_libroar_set_server() to set server (This may be needed
       for bad NAT firewalls)
    2. Use non-blocking connect. Also changes the prio to -3 to be in
       front of pulse plugin (feel free to adjust pulse and roarplugin
       to -1 and -2). My arguments why I think this is the right way
       still stands. See my mail 'Re: RoarAudio output plugin for cmus'
       from Tue, 30 Nov 2010 11:55:00 +0100
Hope you like the patch.
Thanks for your work.

Thanks for the update!

Can you please rebase your patch on top of either -master or -maint
branch? Both git-am and git-apply refuse to apply it as-is.

                Gregory

[Johannes Weißl]

Post by Gregory Petrosyan
Can you please rebase your patch on top of either -master or -maint
branch? Both git-am and git-apply refuse to apply it as-is.

The patch applies fine to both master and maint, but you can't use "git
am" (old school diff file).


Johannes

[Gregory Petrosyan]

Post by Johannes Weißl

Post by Gregory Petrosyan
Can you please rebase your patch on top of either -master or -maint
branch? Both git-am and git-apply refuse to apply it as-is.

The patch applies fine to both master and maint, but you can't use "git
am" (old school diff file).

Oh, sorry, my fault — I thought git-apply can handle old school files as well.

Applied to both master and maint!

                Gregory